Open
Conversation
|
Member
|
My current plan is to make 3D buildings a Flavor parameter, boolean true/false. The majority of basemap use cases are 2D only. the styles hosted at https://protomaps.com/api are pre-generated style JSONs where you have no control over Flavor parameters, but loading from the npm package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
You've got an awesome project, which apparently also included 3D-data. I wasn't aware of that as the basestyles don't leverage it.
I've added a small snippet to the basestyle to use that 3D-support to show it of. Copied it out of my own fork of the style (MapComplete-Sunny), so it should work, but I have to admit that I didn't test it in the environment here.
Anyway, here is how it looks in MapComplete: