fix: missing minZoom on towns #510
Conversation
On towns with a population, it would fall back to the default places zoom of 7. This sets a mininum of 8, similar to other place types. Also sets fallback population of cities to 50k instead of 5k ref protomaps#506
| @@ -90,7 +90,11 @@ public Places(CountryCoder countryCoder) { | |||
| rule( | |||
| with("place", "city"), | |||
| without("population"), | |||
| use("population", 5000), | |||
| use("population", 50000), | |||
There was a problem hiding this comment.
- Per the original code, this should have been
5000-- because most big cities already have population values. Please revise. - The minZoom is fine at 8 (just 1 more than with populations). Your change is good.
- (The later population_rank should be set as well so client side collisions are rational.)
There was a problem hiding this comment.
The population for towns is set to 10k tho, shouldn't cities be higher? Or at least the same?
Note that I didn't touch the minZoom for cities, the diff is just rendering a bit confusingly here
There was a problem hiding this comment.
@nvkelso The current behaviour is incorrect since some capitals (!) are not shown, while some small, unrelated villages are visible. Could you give us any guidance what a fitting fix would be? We're open to making a PR.
| use("population", 50000), | ||
| use("minZoom", 8) | ||
| ), | ||
| rule( |
There was a problem hiding this comment.
I wouldn't have a separate rule for towns with population – they are used interchangeably with cities outside of Europe. Please remove.
There was a problem hiding this comment.
According to OSM wiki, the median population of cities is 130k, whereas for towns it's ranging (by country) from 3k to 35k. While cities and towns may be interchangeably used sometimes, I still feel like towns are generally of less importance, wouldn't you agree?
At zoom 7, we're displaying small towns like Sursee (10k population) alongside big cities, which creates a very cluttered map unlike most other styles. Towns with a population are literally displayed before cities without a population.
On towns with a population, it would fall back to the default places zoom of 7. This sets a mininum of 8, similar to other place types.
Also sets fallback population of cities to 50k instead of 5k
ref #506
Before & after: