Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel 8 compile error fix #19576

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

20083017
Copy link

No description provided.

@shaod2
Copy link
Member

shaod2 commented Dec 10, 2024

Hi thanks for the contribution.

Could you provide any context of this PR?

@shaod2 shaod2 requested a review from zhangskz December 10, 2024 17:19
@acozzette acozzette added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Dec 10, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Dec 10, 2024
@zhangskz
Copy link
Member

I believe these were added to ensure protobuf continues to work for older Bazel versions i.e. Bazel 7: 41be409, so this change would break those.

Do you have more details on the error you hit and why you believe this would help?

@comius
Copy link
Contributor

comius commented Dec 10, 2024

Problem is the reference to top-level cc_proto_aspect, which needs to be done via bazel_features/proto_bazel_features, so that on Bazel 8, there's no reference to in, while it needs to be present on older Bazels.

I also believe this problem is only on main branch, not on 29.x releases.

@20083017
Copy link
Author

20083017 commented Dec 12, 2024

Problem is the reference to top-level cc_proto_aspect, which needs to be done via bazel_features/proto_bazel_features, so that on Bazel 8, there's no reference to in, while it needs to be present on older Bazels.

I also believe this problem is only on main branch, not on 29.x releases.

yes, that's the reason! ^_^

@20083017
Copy link
Author

Hi thanks for the contribution.

Could you provide any context of this PR?

image

@20083017
Copy link
Author

20083017 commented Dec 12, 2024

seems like the pr is working with bazel 7.3.0 and bazel 8, @shaod2 @zhangskz @comius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants