-
Notifications
You must be signed in to change notification settings - Fork 15.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel 8 compile error fix #19576
base: main
Are you sure you want to change the base?
bazel 8 compile error fix #19576
Conversation
Hi thanks for the contribution. Could you provide any context of this PR? |
I believe these were added to ensure protobuf continues to work for older Bazel versions i.e. Bazel 7: 41be409, so this change would break those. Do you have more details on the error you hit and why you believe this would help? |
Problem is the reference to top-level cc_proto_aspect, which needs to be done via bazel_features/proto_bazel_features, so that on Bazel 8, there's no reference to in, while it needs to be present on older Bazels. I also believe this problem is only on main branch, not on 29.x releases. |
yes, that's the reason! ^_^ |
No description provided.