Upload parallelism and retries #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesarosen
reviewed
Sep 16, 2021
Comment on lines
+159
to
+180
| completion: { result in | ||
| switch result { | ||
| case let .success(airtableTree): | ||
| self?.logger.log(.upload, "Successfully uploaded tree.") | ||
| self?.database.save([airtableTree], sentFromThisDevice: true) | ||
| self?.database.remove(tree: tree) { | ||
| self?.currentUploads[tree.phImageId] = nil; | ||
| if (self != nil && self!.currentUploads.count == 0) { | ||
| self?.presentUploadButton(isUploading: false) | ||
| } | ||
| self?.presentTreesFromDatabase() | ||
| self?.uploadLocalTreesRecursively() | ||
| } | ||
| case let .failure(error): | ||
| self?.failedUploadCount[tree.phImageId] = (self?.failedUploadCount[tree.phImageId] ?? 0) + 1 | ||
| self?.currentUploads[tree.phImageId] = nil; | ||
| self?.update(uploadProgress: 0.0, for: tree) | ||
| self?.logger.log(.upload, "Error when uploading a local tree: \(error)") | ||
| self?.uploadLocalTreesRecursively() | ||
| if (self != nil && self!.currentUploads.count == 0) { | ||
| self?.presentUploadButton(isUploading: false) | ||
| } |
There was a problem hiding this comment.
uploadLocalTreesRecursively is getting a little long. The completion callback seems like a good candidate for extraction. It seems to only use self and tree.
jamesarosen
reviewed
Sep 16, 2021
jamesarosen
reviewed
Sep 21, 2021
| let sortedTrees = trees.sorted(by: \.createDate, order: .descending) | ||
| while (self != nil && self!.currentUploads.count < self!.maxConcurrentUploads && self!.currentUploads.count < trees.count) { | ||
|
|
||
| guard let tree = sortedTrees.first(where: { treeEntry in self?.currentUploads[treeEntry.phImageId] == nil && (self?.failedUploadCount[treeEntry.phImageId] ?? 0) < self!.maxUploadAttempts}) else { |
|
Thanks for this folks, we used it as inspiration for #47 🙌🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt at making photo uploads parallel and adding a retry mechanism as well.
3 attempts are made for each image. Currently, if the registration on AirTable fails, it will also re-upload the entire image which is not ideal.
Relates to issues #35 and #37.