feat(console): App storage billing integration #2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosmin-Parvulescu
changed the base branch from
main
to
feat/console/App-storage-package-modal
Cosmin-Parvulescu
force-pushed
the
feat/console/App-storage-package-modal
branch
2 times, most recently
from
191a751
to
06056e9
Compare
Cosmin-Parvulescu
force-pushed
the
feat/console/App-storage-billing-integration
branch
from
a052837
to
f98bb5c
Compare
Base automatically changed from
feat/console/App-storage-package-modal
to
main
February 12, 2024 13:43
Cosmin-Parvulescu
force-pushed
the
feat/console/App-storage-billing-integration
branch
from
18d28f6
to
51219ee
Compare
Cosmin-Parvulescu
force-pushed
the
feat/console/App-storage-billing-integration
branch
from
eeeccaa
to
0191aed
Compare
betimshahini
requested changes
Feb 15, 2024
| @@ -24,6 +25,7 @@ const AppDataStorageModal: React.FC<AppDataStorageModalProps> = ({ | |||
| subscriptionFetcher, | |||
| currentPackage, | |||
| topUp = false, | |||
| currentCost = 0, | |||
There was a problem hiding this comment.
Is there a reason to name this cost as opposed to price? Preferably all wording around this should be uniform, ie. price.
| @@ -262,14 +263,19 @@ export const action: ActionFunction = getRollupReqFunctionErrorWrapper( | |||
|
|
|||
| URN = metaDel.URN as IdentityRefURN | |||
|
|
|||
| const delSub = event.data.object as Stripe.Subscription | |||
| delSub.items.data.forEach(async (item) => { | |||
There was a problem hiding this comment.
This should be converted to an array of promises which can be Promise.all()d, otherwise some of these async calls may run concurrently with the promises below or not finish at all.
apps/console/bindings.d.ts
Outdated
| @@ -22,6 +22,8 @@ interface Env { | |||
| SECRET_STRIPE_WEBHOOK_SECRET: string | |||
| SECRET_STRIPE_PRO_PLAN_ID: string | |||
| SECRET_STRIPE_GROUP_SEAT_PLAN_ID: string | |||
| SECRET_STRIPE_APP_DATA_STORAGE_STARTER_PRICE_ID: string | |||
There was a problem hiding this comment.
Can we combine these two into a singular SECRET_STRIPE_APP_DATA_STORAGE_PRICE_IDS containing JSON content representing the same? The second level price IDs (ie. service-specific tiers) don't pollute the env var space too much.
betimshahini
requested changes
Feb 20, 2024
.github/workflows/main-console.yaml
Outdated
| @@ -66,6 +67,8 @@ jobs: | |||
| SECRET_STRIPE_WEBHOOK_SECRET: ${{ secrets.SECRET_STRIPE_WEBHOOK_SECRET_DEV }} | |||
| SECRET_STRIPE_PRO_PLAN_ID: ${{ secrets.SECRET_STRIPE_PRO_PLAN_ID_DEV }} | |||
| SECRET_STRIPE_GROUP_SEAT_PLAN_ID: ${{ secrets.SECRET_STRIPE_GROUP_SEAT_PLAN_ID_DEV }} | |||
| SECRET_STRIPE_APP_DATA_STORAGE_PRICE_IDS: ${{ secrets.SECRET_STRIPE_APP_DATA_STORAGE_PRICE_IDS_DEV }} | |||
| SECRET_STRIPE_APP_DATA_STORAGE_SCALE_PRICE_ID: ${{ secrets.SECRET_STRIPE_APP_DATA_STORAGE_SCALE_PRICE_ID_DEV }} | |||
There was a problem hiding this comment.
We probably don't need this at the top level anymore, right?
There was a problem hiding this comment.
Yeah, just the PRICE_IDS
betimshahini
approved these changes
Feb 20, 2024
betimshahini
deleted the
feat/console/App-storage-billing-integration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Testing
Checklist