Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(all): Update package.json metadata #2811

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(all): Update package.json metadata #2811

wants to merge 2 commits into from

Conversation

alfl
Copy link
Contributor

@alfl alfl commented Jan 8, 2024 •
edited
Loading

Description

Streamlines license and author fields.

Related Issues

Testing

  • Installed all packages to validate them through linters in yarn and, where possible, npm.

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@alfl alfl added the bug Indicates an unexpected problem or unintended behavior label Jan 8, 2024
@alfl alfl added this to the Future milestone Jan 8, 2024
@alfl alfl requested review from szkl and betimshahini January 8, 2024 21:12
@alfl alfl self-assigned this Jan 8, 2024
@alfl
fix(all): Update package.json metadata to unify license and author fi…
75e5e53 
…elds.

fix(all): Remove emails, some missing fixes.

fix(logbridge): add admin email

fix(ping): Added admin email

fix(test): Add admin email.

fix(object): Added admin email.

fix(platform): Add admin email.

fix(edges): Add admin  email.

fix(email): Add admin email.

fix(billing): Add admin email.

fix(rollup): Add admin email and UNLICENSED license.

fix(security): Add admin email.

fix(alchemy-client): Add admin email.

fix(core): Add admin email.

fix(identity): Add admin email.

fix(images): Add admin email.

fix(starbase): Add admin email.

fix(galaxy): Add admin email.

fix(account): Add admin email.

fix(authorization): Add admin email.

fix(analytics): Add admin email.

fix(types): Add admin email.

fix(urns): Add admin  email.

fix(galaxy-client): Add admin email.

fix(platform-middleware): Add admin email.

fix(utils): Add admin email.

fix(platform-clients): Add admin email.

fix(packages): Add admin email.

fix(errors):  Add admin email.

fix(design-system): Add admin email.

fix(console): Add admin  email.

fix(profile): Add  admin email.

fix(passport): Add admin email.

fix(apps): Add admin email.

fix(object): Removed package lock.
@alfl alfl marked this pull request as ready for review January 9, 2024 21:34
@alfl alfl requested a review from maurerbot January 9, 2024 21:34
szkl
szkl previously approved these changes Jan 9, 2024
View reviewed changes
maurerbot
maurerbot requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@maurerbot maurerbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This license has no meaning since it not a private package. Did you mean unlicense?

Should just leave blank to inherit top level license

@alfl
Copy link
Contributor Author

alfl commented Jan 10, 2024

This license has no meaning since it not a private package. Did you mean unlicense?

No.

Should just leave blank to inherit top level license

Most of the sub-packages are marked private: true. Those should also be UNLICENSED, per the docs: https://docs.npmjs.com/cli/v10/configuring-npm/package-json

@alfl alfl marked this pull request as draft January 11, 2024 14:21
@szkl szkl requested a review from maurerbot January 12, 2024 03:46
@betimshahini betimshahini dismissed szkl’s stale review January 31, 2024 16:07

The merge-base changed after approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szkl szkl szkl left review comments

@betimshahini betimshahini Awaiting requested review from betimshahini

@maurerbot maurerbot Awaiting requested review from maurerbot

Requested changes must be addressed to merge this pull request.

Assignees

@alfl alfl

Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
Future
Development

Successfully merging this pull request may close these issues.

chore(platform): Streamline author and license across package.json files
3 participants
@alfl @maurerbot @szkl