Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggests using docker compose to provision dev dbs #1732

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

suggests using docker compose to provision dev dbs #1732

wants to merge 1 commit into from

Conversation

elmariachi111
Copy link

No description provided.

rrrliu
rrrliu reviewed Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@rrrliu rrrliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this and apologies for the late review! It'd be great to dockerize more items going forward.

Left one comment -- also looks like there are some merge conflicts.

README.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add instructions here for installing Docker and starting the Docker daemon, before calling any of the localdb scripts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrrliu rrrliu rrrliu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elmariachi111 @rrrliu