pass in extra validation arguments to tryDeserializeNewStorage

proofcarryingdata · Dec 18, 2023 · 0509323 · 0509323
1 parent 0b1e4fc
commit 0509323
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/apps/passport-client/src/dispatch.ts b/apps/passport-client/src/dispatch.ts
@@ -752,6 +752,7 @@ async function doSync(
       state.serverStorageRevision,
       state.serverStorageHash,
       state.self,
+      state.identity,
       state.pcds,
       state.subscriptions
     );

diff --git a/apps/passport-client/src/useSyncE2EEStorage.tsx b/apps/passport-client/src/useSyncE2EEStorage.tsx
@@ -261,6 +261,7 @@ export async function downloadAndMergeStorage(
   knownServerRevision: string | undefined,
   knownServerHash: string | undefined,
   appSelf: User,
+  appIdentity: Identity,
   appPCDs: PCDCollection,
   appSubscriptions: FeedSubscriptionManager
 ): Promise<SyncStorageResult> {
@@ -290,6 +291,8 @@ export async function downloadAndMergeStorage(
   // Deserialize downloaded storage, which becomes the default new state if no
   // merge is necessary.
   const downloaded = await tryDeserializeNewStorage(
+    appSelf,
+    appIdentity,
     storageResult.value.storage
   );
   if (downloaded === undefined) {
@@ -352,7 +355,12 @@ export async function downloadAndMergeStorage(
   };
 }
 
+/**
+ * {@link appSelf} and {@link appIdentity} are used solely for validation purposes.
+ */
 export async function tryDeserializeNewStorage(
+  appSelf: User,
+  appIdentity: Identity,
   storage: SyncedEncryptedStorage
 ): Promise<
   | undefined
@@ -371,10 +379,9 @@ export async function tryDeserializeNewStorage(
     if (
       !validateAndLogRunningAppState(
         "downloadStorage",
-        undefined,
-        undefined,
-        pcds,
-        true
+        appSelf,
+        appIdentity,
+        pcds
       )
     ) {
       throw new Error("downloaded e2ee state failed to validate");