Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go 1.7 #420

Merged
merged 1 commit into from
Jan 15, 2017
Merged

Use go 1.7 #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ sudo: false

language: go
go:
- 1.5
- 1.7.x
Copy link
Contributor

@mdlayher mdlayher Jan 12, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Travis, you can actually do 1.x to resolve to the latest point release of Go, so in this case, 1.7.4.

I do it here: https://github.com/mdlayher/wifi/blob/master/.travis.yml#L3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, good point, I think we want to use 1.7.x to keep things pinned to a release.

- tip

script:
Expand Down
2 changes: 1 addition & 1 deletion circle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ machine:
environment:
DOCKER_IMAGE_NAME: prom/node-exporter
QUAY_IMAGE_NAME: quay.io/prometheus/node-exporter
DOCKER_TEST_IMAGE_NAME: quay.io/prometheus/golang-builder:1.6-base
DOCKER_TEST_IMAGE_NAME: quay.io/prometheus/golang-builder:1.7-base
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this resolve to 1.7.4?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, will check the circle output.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdurrheimer It looks like the quay image for golang-builder is 1.7.3, I'm not sure what the difference is between -base and -main.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Came across this too and created prometheus/golang-builder#19 since I couldn't figure it out. Also looks like each variant has their own slightly different copy of the build script etc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated promu0 to 1.7.4, but we need to update the quay.io packages. I'm not sure how to do that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "update the quay.io packages" ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to make sure that we get builds from CircleCI to use 1.7.4 for the next release.

REPO_PATH: github.com/prometheus/node_exporter
pre:
- sudo curl -L -o /usr/bin/docker 'https://s3-external-1.amazonaws.com/circle-downloads/docker-1.9.1-circleci'
Expand Down