-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect operator autopilot health metrics #195
base: master
Are you sure you want to change the base?
Conversation
f16696b
to
d8adc02
Compare
Ignore previous iterations of this comment I was building off my local master... 🤦 Fixing test issues and lint problems now. |
75072ae
to
4a57f65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. A few questions/remarks but nothing blocking.
fb2569a
to
bda7d1d
Compare
I had to soft rebase off origin's head, and then For anyone who journeys here and hits something similar, hopefully https://gist.github.com/patik/b8a9dc5cd356f9f6f980#the-harder-and-less-flexible-way helps to clean up. Also, for DCO bot whatever reason commits from my Windows desktop with my main email never pass the DCO check. |
Signed-off-by: Charles Zaffery <[email protected]>
bda7d1d
to
96246aa
Compare
Apologies for the very belated answer. Would you be able to rebase? |
@simonpasquier I can. In Consul 1.9 they also added a lot of new autopilot metrics that are extremely useful. Do you have a way to deal with version breakage? |
This extends the exporter to collect everything exposed by the https://www.consul.io/api-docs/operator/autopilot#read-health endpoint. Naming is weird, but I wanted to call out that this isn't something that should typically be collected unless you need to keep track of really low level stats.
This is my first time extending a prometheus exporter and I find this one super helpful, thank you all for all your hard work and please let me know if anything here is super wrong. :)