Implement probe_failure_info Metric
#1334
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slrtbtfs
force-pushed
the
probe_failure_info
branch
from
4df06d6 to
73630e8
Compare
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
slrtbtfs
force-pushed
the
probe_failure_info
branch
from
4630786 to
4f0dddb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft for implementing #1077.
The basic idea is that the information about Probe failures that is already logged is additionally made available via the
probe_failure_infometric.The underlying mechanisms are mainly implemented in
prober/prober.goandprober/handler.go, the rest of the diff is mostly refactoring.Before merging, this should still get some improved tests and polishing, however I'd like to get some early feedback about whether you agree with the implementation approach in general.
There is also space for improvement as some error messages provide only limited detail (e.g. the generic
HTTP request failedone). IMO this makes most sense as a follow up once the basic implementation of this metric is merged.