Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging improvements #4113

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Commits on Nov 6, 2024

  1. ref(webhook): return error if unable to parse group key

    Addresses feedback from another PR
    prometheus#4089 (comment)
    
    Signed-off-by: TJ Hoplock <[email protected]>
    tjhop committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    38ee8ad View commit details
    Browse the repository at this point in the history
  2. fix(silence): log errors at ERROR level instead of INFO

    Signed-off-by: TJ Hoplock <[email protected]>
    tjhop committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    e8d0edf View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. chore(notify): make logging more consistent, converge on group_key

    This changes the majority of our `Notify()` implementations to set up a
    new logger with the group key attached under the key name `group_key`,
    and then to use that logger in all subsequent calls to the logger,
    including passing it through to further functions that accept loggers
    via params.
    
    A few of the notify implementations are more complicated; they either
    extract the key later in their `Notify()` implementation or within sub
    methods, or even conditionally like with sns. I left those mostly as is
    for now, as they seem to be more snow-flake-y.
    
    Signed-off-by: TJ Hoplock <[email protected]>
    tjhop committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    1a116a1 View commit details
    Browse the repository at this point in the history