Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set testdata / example CA expiry to 20 years from issue date #4112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dswarbrick
Copy link

Also add human-readable x509 text format (as requested by @SuperQ in related PR prometheus/prometheus#14696)

Fixes: #3962

Also add human-readable x509 text format.

Signed-off-by: Daniel Swarbrick <[email protected]>
@dswarbrick
Copy link
Author

Incidentally, the expiry dates of the certs (both CA and server/client) seem to be a bit wild and inconsistent. The original CA had a lifetime of only 5 years, whilst the node{1,2}.pem certs had a 100 year lifetime (!). Usually the CA lifetime would be longer than host/node certs (although 100 years is a bit excessive).

It might be worth regenerating all the test / example certs with more sane lifetimes - and possibly consider bumping the key length to 4096 bits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test certificates expiring in <2y
1 participant