chore: Refactor OpenStackSDConfig

[nutmos]

Description

Refactor OpenStackSDConfig

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

• CHANGE (fix or feature that would cause existing functionality to not work as expected)
• FEATURE (non-breaking change which adds functionality)
• BUGFIX (non-breaking change which fixes an issue)
• ENHANCEMENT (non-breaking change which improves existing functionality)
• NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

1. Add the validation in the type.
2. Add the test cases for type verification.

Fixes #7209

[mviswanathsai]

Hey! thanks for the contribution.
On top of this, you would also need to add e2e test cases and version checks wherever applicable. You can ping me if you need any help with that!

[nutmos]

@mviswanathsai Hi, I completed all of the requirements already. Please review.

[nutmos]

@mviswanathsai Hi, do you have any chance to take a look at my PR?

[slashpai]

For string fields we need to add the minlength validation

// +kubebuilder:validation:MinLength:=1

[nutmos]

@mviswanathsai @slashpai Hi, I fixed already. Please review. Thank you!

[slashpai]

Can you add testcases for all the fields updated in API in e2e test file?

[nutmos]

@slashpai I updated the pattern as suggested already along with the new test cases to cover field updates.
Also, I would like to highlight that there are other HTTP-related fields use this pattern, which I will help updating them later as well.

[mviswanathsai]

Great job with the extensive testcases, just one comment.
CC: @slashpai

[nutmos]

@mviswanathsai I added 2 more cases to cover the missing required fields.

[nutmos]

@mviswanathsai Update the code with rebase from the main branch. Please review.

[mviswanathsai]

LGTM!
CC: @slashpai

[nutmos]

@slashpai any action needed from my side?

[slashpai]

Thank you, lgtm