Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for passing secrets as docker build args #232

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Greven145
Copy link

🧯 Bugfix Description

This PR introduces the ability to enable user secrets during build command execution and the substitution of build arguments from inputs and secrets. This closes #230.

🧰 Technical Solution

  • Create a new cli flag --use-secrets and add it to the build command
  • Unlock secrets if --use-secrets is specified, regardless of the command's default
  • Include the --secret-password option for the build command (for non-interactive builds)
  • Add logic to substitute parameter values in docker build args
  • Add tests for docker build arg substitution

@prom3theu5
Copy link
Owner

Thanks for this - I'll check over it tonight :)

@Greven145
Copy link
Author

Hey! Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inputs are not resolved for docker build args
3 participants