-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configuration: Add support for Envoys MaxStreamDuration configuration #6895
base: main
Are you sure you want to change the base?
configuration: Add support for Envoys MaxStreamDuration configuration #6895
Conversation
Hi @nickburgin! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace |
f572f60
to
7b6bd26
Compare
Fixes projectcontour#6873 Signed-off-by: Nick Burgin <[email protected]>
7b6bd26
to
ee8ebee
Compare
I wasn't able to add labels, but this should be considered |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6895 +/- ##
==========================================
+ Coverage 80.70% 80.79% +0.09%
==========================================
Files 131 131
Lines 19805 19828 +23
==========================================
+ Hits 15983 16021 +38
+ Misses 3532 3522 -10
+ Partials 290 285 -5
|
…uration Adds entirely missing test coverage for the timeouts configuration section in servecontext Signed-off-by: Nick Burgin <[email protected]>
There were no tests for any of the timeout settings. I have added a basic test case for those to ensure they are all passed through as expected. |
Fixes #6873
Signed-off-by: Nick Burgin [email protected]