Remove workaround for controller-tools typealias bug

[tsaarni]

This PR removes the workaround which was applied due to controller-tools issue kubernetes-sigs/controller-tools#1088. The issue was fixed in v0.17.1.

[tsaarni]

Regarding generate-api-docs.sh:

The workaround is still needed in hack/generate-api-docs.sh since following still stands #6709 (comment)

Same problem concerns github.com/ahmetb/gen-crd-api-reference-docs, it also cannot handle inline type alias. The error comes from github.com/kubernetes/gengo which does have some fixes in main. It looked like the behavior is chosen by compiler version used in build, but so far I did not get it to work even if stepping up go version in gen-crd-api-reference-docs go.mod.

The problem there is that we install latest tagged version, which generally makes sense

contour/hack/generate-api-docs.sh

Line 25 in 3c3fb0a

go install github.com/ahmetb/gen-crd-api-reference-docs

but in this case latest tag is v0.3.0 from year 2021

$ go version -m ~/go/bin/gen-crd-api-reference-docs | grep mod
        mod     github.com/ahmetb/gen-crd-api-reference-docs    v0.3.0  h1:+XfOU14S4bGuwyvCijJwhhBIjYN+YXS18jrCY2EzJaY=

If upgrading to latest (untagged) version with go install github.com/ahmetb/gen-crd-api-reference-docs@latest then generating API docs would work without workaround.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (3c3fb0a) to head (41ccd07).
Report is 12 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6874   +/-   ##
=======================================
  Coverage   81.05%   81.05%           
=======================================
  Files         133      133           
  Lines       20026    20026           
=======================================
  Hits        16232    16232           
  Misses       3500     3500           
  Partials      294      294           

[skriss]

If upgrading to latest (untagged) version with go install github.com/ahmetb/gen-crd-api-reference-docs@latest then generating API docs would work without workaround.

I'd say let's pin it to the latest commit SHA so that it's a stable version so we don't get random changes over time, but I'm fine using an untagged version. Should be able to use go.mod to manage the version and then just go run it from the script.

[tsaarni]

xref #6885