StripTrailingHostDot: Expose new configuration option to enable Envoy removal of trailing dot on hostnames

[saley89]

Fixes #6334

This PR adds:

• A new configuration option in the NetworkParameters of Contour.
• The new option is called StripTrailingHostDot.
• This option when set to true will configure all Envoy routing to strip any trailing dot from a hostname before processing the request. This will allow it to be matched by any existing routes for that hostname without a dot.
• Tests to show the configuration option set to to true being added to the underlying listener configuration.

[github-actions]

Hi @saley89! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace

[github-actions]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 14d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

• Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
• Mark this PR as fresh by commenting or pushing a commit
• Close this PR
• Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

[saley89]

Any thoughts on this one? This is quite a small, safe change adding a new configuration flag to add the option to the configured listener.

It is based heavily on the XffNumTrustedHops flag and usage in similar areas of the code.

[codecov]

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.06%. Comparing base (63bb34a) to head (7f1150b).
Report is 24 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/contour/serve.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6792   +/-   ##
=======================================
  Coverage   81.05%   81.06%           
=======================================
  Files         133      133           
  Lines       20026    20037   +11     
=======================================
+ Hits        16232    16242   +10     
- Misses       3500     3501    +1     
  Partials      294      294           

Files with missing lines	Coverage Δ
cmd/contour/servecontext.go	84.54% <100.00%> (+0.03%)	⬆️
internal/contourconfig/contourconfiguration.go	98.19% <100.00%> (+0.01%)	⬆️
internal/envoy/v3/listener.go	98.50% <100.00%> (+<0.01%)	⬆️
internal/xdscache/v3/listener.go	92.05% <100.00%> (+0.06%)	⬆️
pkg/config/parameters.go	88.09% <100.00%> (+0.03%)	⬆️
cmd/contour/serve.go	21.72% <0.00%> (-0.03%)	⬇️

[saley89]

@tsaarni for this one is there anything else I need to do/add or is it in a state that it can be added to an upcoming release? I ask mainly for our planning purposes as we are maintaining a fork for now with some of our changes and will take the upstream once they become merged.

Thanks.

[github-actions]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 14d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

• Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
• Mark this PR as fresh by commenting or pushing a commit
• Close this PR
• Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack