Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTTPRequestRedirectPolicy StatusCode to use RedirectResponseCode #6789

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Add 303, 307, 308 as valid envoy redirect route status codes

276ae32
Select commit
Loading
Failed to load commit list.
Open

Update HTTPRequestRedirectPolicy StatusCode to use RedirectResponseCode #6789

Add 303, 307, 308 as valid envoy redirect route status codes
276ae32
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 8, 2025 in 0s

81.03% (-0.03%) compared to d05f43a

View this Pull Request on Codecov

81.03% (-0.03%) compared to d05f43a

Details

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (d05f43a) to head (276ae32).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
internal/envoy/v3/route.go 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6789      +/-   ##
==========================================
- Coverage   81.05%   81.03%   -0.03%     
==========================================
  Files         133      133              
  Lines       20026    20032       +6     
==========================================
  Hits        16232    16232              
- Misses       3500     3506       +6     
  Partials      294      294              
Files with missing lines Coverage Δ
internal/dag/dag.go 98.78% <ø> (ø)
internal/dag/httpproxy_processor.go 91.00% <100.00%> (ø)
internal/envoy/v3/route.go 80.41% <0.00%> (-0.60%) ⬇️