Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add resources to capsule-proxy-certgen helm job #595

Merged

Conversation

devantler
Copy link
Contributor

Closes #594

@devantler devantler force-pushed the capsule-proxy-certgen-resources branch from 0a8e009 to 69a4db9 Compare December 13, 2024 08:10
@devantler devantler changed the title Add resources to capsule-proxy-certgen job feat: Add resources to capsule-proxy-certgen job Dec 13, 2024
@devantler devantler force-pushed the capsule-proxy-certgen-resources branch from 69a4db9 to 0dcd7b0 Compare December 13, 2024 08:13
@prometherion prometherion changed the title feat: Add resources to capsule-proxy-certgen job feat(helm): add resources to capsule-proxy-certgen job Dec 13, 2024
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll amend the commit message via squash.

@prometherion prometherion changed the title feat(helm): add resources to capsule-proxy-certgen job feat: add resources to capsule-proxy-certgen helm job Dec 13, 2024
@prometherion prometherion merged commit 130939a into projectcapsule:main Dec 13, 2024
8 of 11 checks passed
@devantler devantler deleted the capsule-proxy-certgen-resources branch December 17, 2024 08:54
@devantler
Copy link
Contributor Author

devantler commented Dec 17, 2024

@prometherion any chance for a release before Christmas? I have an issue depending on this change, so I would love to solve it without any "hacky" solution 🔫✌🏻🎄

@prometherion
Copy link
Member

Sorry, I'm busy with personal stuff, not sure if @oliverbaehler is up for it.

Sorry for this!

@oliverbaehler
Copy link
Collaborator

@devantler i ll try to get it done until friday, thanks for your patience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting Resources on capsule-proxy-certgen job via Helm values
3 participants