feat: allow user to gets list of his tenants

[anatolychernov]

PR by issue 328

[anatolychernov]

Hello @oliverbaehler,

Could you clarify info about two failed checks:
Check Commit / commit_lint (pull_request) Failing after 11s
Go Lint / lint (pull_request) Failing after 1m

Should I fix something?

[anatolychernov]

It seems I've fixed commit's checks

[anatolychernov]

Hello,

Could you start other checks from workflow?

[prometherion]

@anatolychernov golangci-lint is complaining since you're relying on the slices package which has been introduced with the v1.21.

We should first get the proxy update to this version of Go, then we can get this merged. Are you up to take care of this too?

[anatolychernov]

@anatolychernov golangci-lint is complaining since you're relying on the slices package which has been introduced with the v1.21.

We should first get the proxy update to this version of Go, then we can get this merged. Are you up to take care of this too?

Hello,

I've updated Go version to 1.21 in go.mod

[prometherion]

All the commits have the same subject, making hard to keep track of the changes.

Furthermore, Go 1.21 should be configured also on the CI actions, not only on the go.mod file.

e.g.: https://github.com/projectcapsule/capsule/blob/318d7d076a4a7640f6459ffc14d8e965380d344d/.github/workflows/e2e.yml#L46-L48

[anatolychernov]

All the commits have the same subject, making hard to keep track of the changes.

Furthermore, Go 1.21 should be configured also on the CI actions, not only on the go.mod file.

e.g.: https://github.com/projectcapsule/capsule/blob/318d7d076a4a7640f6459ffc14d8e965380d344d/.github/workflows/e2e.yml#L46-L48

This link is from capsule project, not from capsule-proxy. But I've updated go version in Docker files.

[anatolychernov]

@prometherion

If we don't have any more questions, can we proceed checks?

[prometherion]

This link is from capsule project, not from capsule-proxy

The same Go runtime settings must be reported here:

capsule-proxy/.github/workflows/lint.yaml

Lines 13 to 24 in 2333253

	jobs:
	golangci:
	name: lint
	runs-on: ubuntu-20.04
	steps:
	- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
	- name: Run golangci-lint
	uses: golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc # v3.7.0
	with:
	version: v1.51.2
	only-new-issues: false
	args: --timeout 5m --config .golangci.yml

Otherwise, the golangci-lint won't be able to access the slices package from the standard library.

[anatolychernov]

This link is from capsule project, not from capsule-proxy

The same Go runtime settings must be reported here:

capsule-proxy/.github/workflows/lint.yaml

Lines 13 to 24 in 2333253

	jobs:
	golangci:
	name: lint
	runs-on: ubuntu-20.04
	steps:
	- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
	- name: Run golangci-lint
	uses: golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc # v3.7.0
	with:
	version: v1.51.2
	only-new-issues: false
	args: --timeout 5m --config .golangci.yml

Otherwise, the golangci-lint won't be able to access the slices package from the standard library.

Hello @prometherion,

Do you mean something like this?

jobs:
  golangci:
    name: lint
    runs-on: ubuntu-20.04
    steps:
      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
      - name: Install Go
        uses: actions/setup-go@v4
        with:
          go-version: '1.21'
          cache: false
      - name: Run golangci-lint
        uses: golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc # v3.7.0
        with:
          version: v1.51.2
          only-new-issues: false
          args: --timeout 5m --config .golangci.yml

[anatolychernov]

@prometherion,

I've added "Install Go" step for lint.yaml

[anatolychernov]

@prometherion, could you proceed checks to get 'Go lint' result?

[anatolychernov]

Hello guys!
@prometherion,
I have rebased my changes to fresh main commits. Could you proceed other workflow checks?

[prometherion]

@anatolychernov do you mind if you git push --force some fixes to get this merged?

[anatolychernov]

@prometherion,
Do you mean that you want to combine these commits into one(squash) or I didn't understand you. Could you clarify it?

[prometherion]

Maintainers are allowed to edit this pull request

I can push yo your branch to fix minor thingies, that would be much easier to get this merged, considering that everytime you have to ask for CI to get triggered since you're a first-time contributor 😅

[anatolychernov]

Maintainers are allowed to edit this pull request

I can push yo your branch to fix minor thingies, that would be much easier to get this merged, considering that everytime you have to ask for CI to get triggered since you're a first-time contributor 😅

Yes, please do it. It will be great.

[anatolychernov]

Maintainers are allowed to edit this pull request
I can push yo your branch to fix minor thingies, that would be much easier to get this merged, considering that everytime you have to ask for CI to get triggered since you're a first-time contributor 😅

Yes, please do it. It will be great.

@prometherion hello!
Do you have any updates about minor fixes?

[anatolychernov]

I've signed off all my commits, but merging check is still blocked. Is it a glitch?

[prometherion]

@anatolychernov I'm sorry for this tedious PR but I think we're there, eventually!

Since you're a first-time contributor, GI must approved by a project administrator, sorry for this.
Also, the latest golangci-lint seems having issues with the slices packages you used in your contribution: I changed it according to the current libraries we're using in capsule-proxy with the same outcome.
Furthermore, I spotted a bug in the Makefile which was still using the old golangci-lint binary.

Let's praise for the green CI 🙏🏻 and we can finally get this merged: thanks a lot for your patience and your efforts, I appreciate it!

[anatolychernov]

@prometherion Thank you for help!