fix(copy): ignore checksum if duplicate or original does not have one #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
As I was also involved here, I'm going to leave the final review to @winged (or someone else). 🙂 I wonder if it might make sense to add a management script to calculate the missing checksums (via separate PR, that is), to avoid unexpected behaviour in the future. Any thoughts, @winged (and maybe @Yelinz, @czosel)? |
Member
|
Yeah makes sense to make a command to add missing checksum |
nlzet
force-pushed
the
fix/alexandria-file-copy-checksum
branch
from
de4ea2b to
2d4fdca
Compare
Contributor
Author
|
Added new command to generate missing checksums |
Yelinz
reviewed
May 13, 2025
| ) | ||
| ) | ||
|
|
||
| self.stdout.write("") |
Member
There was a problem hiding this comment.
Is this line intentional for spacing?
Contributor
Author
There was a problem hiding this comment.
Yes this was only added for a little bit more clarity in the output
Yelinz
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with @martinwe-adfinis we noticed older files did not have a checksum. So for the fix command when either the original or the new file does not have a checksum we'll skip the sanity check.