[backport 8.x] accessibility fix: facet focus ring styles #3481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's odd to use navbar-toggler for a button that doesn't exist in a .navbar. This lead us to setting a bunch of properties we wouldn't need to set if we just use a .btn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports to 8.x three commits from
mainthat together address accessibility problems with the currentrelease-8.x; namely that facets are difficult to navigate via keyboard because of missing focus ring styles on the facet headers and mobile toggler button.Before: Facet Header with Focus
After: Facet Header with Focus
Before: Show Facets Toggle with Focus
After: Show Facets Toggle with Focus