Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to use importmap and propshaft together when generating #3249

Closed
wants to merge 6 commits into from

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Aug 1, 2024

No description provided.

@jcoyne jcoyne marked this pull request as draft August 2, 2024 13:02
@jcoyne jcoyne closed this Oct 17, 2024
@jcoyne jcoyne deleted the importmap+propshaft branch October 17, 2024 16:38
@jrochkind
Copy link
Member

i see you deleted this, but swapping the order of propshaft vs importmaps would have broken the build in my for-discussion #3360 -- but it could have been fixed again with somewhat more complicated logic and/or actual arguments telling the asset generator which path you want.

Let's talk about it, if not in a community meeting that didn't happen this month, maybe on #3360 , or in slack, or on a voice call we set up, or something!

@jcoyne
Copy link
Member Author

jcoyne commented Oct 17, 2024

The switching the order was something we did in #3340, so that would have rebased out of this PR.

@jrochkind
Copy link
Member

Ah, you're right I got confused -- in fact #3360 depends on ImportMap before Propshaft, so indeed the same thing that is in here and #3340.

(If reversed, the logic would just have to be made more complicated ot support #3360).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants