Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale and smooth samples for non-custom waveforms #782

Merged

Conversation

dpw13
Copy link
Collaborator

@dpw13 dpw13 commented Feb 17, 2024

Partially fixes Benjam and Zylot - Tie-Dye Supernova - prophecies - subconscious feednowhere applets nz+. The issue was that the default waveform is scaled so that it colors the center of the window, which is then zoomed in to produce an outflowing of somewhat random color. Without the amplitude set high enough, the waveform never reaches the center so you only get a black screen.

@kblaschke
Copy link
Member

Those default waveform modes still mostly use the original projectM code, including the "maximize color" stuff etc., so there's quite a good chance that the code does many things wrong. This was one of the few parts I didn't refactor much since the 3.x releases.

You could have a look at the original implementation and cross-check/rewrite any code that's much different from the original. Since it's just calculating a few vertex coordinates, we should be able to get this function to behave nearly identical to Milkdrop.

@dpw13 dpw13 force-pushed the dev/dwagner-circle-amplitude branch from 0071c4e to 2c34784 Compare February 21, 2024 13:30
@kblaschke kblaschke added the bug label Feb 21, 2024
@kblaschke kblaschke added this to the 4.1 milestone Feb 21, 2024
@kblaschke kblaschke merged commit 861c36e into projectM-visualizer:master Feb 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants