a couple of bug fixes, and some refactoring #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had code in application_helper to convert from Fixnum to Date but not Bignum. Fixes project-rhex#7
Similar fix to a225628 but for the "getAgeText" method. Fixes project-rhex#8
moved date handling code into its own method.
We were getting these warnings: [DEVISE] Devise.apply_schema is deprecated and has no effect. Please remove it. [DEVISE] Devise.use_salt_as_remember_token is deprecated and has no effect. Please remove it. Removed apply_schema and use_salt_as_remember_token.
Lower-case with underscores is more Ruby-ish.
|
This is failing on Travis. I have a feeling it has to do with timezones. Would you be able to track that down? |
Some of our test case code only worked east of UTC but not in UTC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issues 7 and 8. Also some minor refactoring.