Remove keycloak id from user model#599
Draft
thescouser89 wants to merge 1 commit intoproject-ncl:masterfrom
Draft
Remove keycloak id from user model#599thescouser89 wants to merge 1 commit intoproject-ncl:masterfrom
thescouser89 wants to merge 1 commit intoproject-ncl:masterfrom
Conversation
The keycloak id is present in the user model to guarantee uniqueness. However, it is also pretty much guaranteed that the username will uniquely identify a single user only. The other reason why this commit removes the keycloak id is because we need to support other ways of authentication (LDAP). LDAP doesn't provide such a keycloak id (but in theory we could use a unique ID from the LDAP entry for the user). However the same user authenticating through LDAP and then through OIDC would be considered 2 different 'persons' because of the different ids. I believe it would be much easier to just use the username to uniquely identify a user as a result.
thescouser89
requested review from
jomrazek and
michalovjan
and removed request for
michalovjan
Contributor
|
@thescouser89 btw, IIRC elytron-oidc is available only in EAP with XP pack which DA is not on. |
Contributor
Author
|
@michalovjan I just transformed DA to use XP pack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keycloak id is present in the user model to guarantee uniqueness. However, it is also pretty much guaranteed that the username will uniquely identify a single user only.
The other reason why this commit removes the keycloak id is because we need to support other ways of authentication (LDAP). LDAP doesn't provide such a keycloak id (but in theory we could use a unique ID from the LDAP entry for the user). However the same user authenticating through LDAP and then through OIDC would be considered 2 different 'persons' because of the different ids.
I believe it would be much easier to just use the username to uniquely identify a user as a result.
Checklist: