Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set per-field values for the maximum length of multi-token matches #96

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Gray-Davidson-00
Copy link

Hugh, I added a dictionary to contain all five max_token_count values. I estimated liberal defaults for all 5. The correct value for max_token_count is employed in label_tokens below. This bypasses the work you did to pass max_token_count as an argument but I couldn't easily figure out how to pass in a dictionary of values. In any case, modifying the dictionary at the top of the file should do what we want here.

Copy link

@moredatarequired moredatarequired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Once you take out the hardcoded check for advertiser it's all done. (as of right now we skip the value we get out of the dictionary if it's not an advertiser)

deepform/data/add_features.py Outdated Show resolved Hide resolved
deepform/data/add_features.py Outdated Show resolved Hide resolved
@moredatarequired moredatarequired changed the title Gray/features work Set per-field values for the maximum length of multi-token matches Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants