forked from jstray/deepform
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set per-field values for the maximum length of multi-token matches #96
Open
Gray-Davidson-00
wants to merge
9
commits into
master
Choose a base branch
from
gray/features_work
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moredatarequired
requested changes
Oct 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Once you take out the hardcoded check for advertiser it's all done. (as of right now we skip the value we get out of the dictionary if it's not an advertiser)
moredatarequired
changed the title
Gray/features work
Set per-field values for the maximum length of multi-token matches
Oct 7, 2020
This reverts commit f8c4f76.
Co-authored-by: Hugh Wimberly <[email protected]>
Co-authored-by: Hugh Wimberly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hugh, I added a dictionary to contain all five max_token_count values. I estimated liberal defaults for all 5. The correct value for max_token_count is employed in label_tokens below. This bypasses the work you did to pass max_token_count as an argument but I couldn't easily figure out how to pass in a dictionary of values. In any case, modifying the dictionary at the top of the file should do what we want here.