Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sdk): change sdk package structure #2091

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Jan 30, 2025

Description

Change sdk package structure

Additional Notes

N/A

Related issue(s)

Related to #1981

Confirmation

Important

We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.

@0xmad 0xmad added the chore Chore tasks label Jan 30, 2025
@0xmad 0xmad self-assigned this Jan 30, 2025
Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Jan 31, 2025 4:23pm

@0xmad 0xmad marked this pull request as ready for review January 30, 2025 18:26
@0xmad 0xmad enabled auto-merge January 30, 2025 18:27
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left some comments/questions

packages/sdk/ts/tally/commitment.ts Outdated Show resolved Hide resolved
packages/sdk/ts/tally/verify.ts Outdated Show resolved Hide resolved
packages/sdk/ts/tree/index.ts Outdated Show resolved Hide resolved
packages/sdk/ts/key/key.ts Outdated Show resolved Hide resolved
@0xmad 0xmad force-pushed the refactor/sdk-structure branch from 5c71734 to b1084fd Compare January 31, 2025 16:13
@0xmad 0xmad requested a review from ctrlc03 January 31, 2025 16:13
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ctrlc03 ctrlc03 force-pushed the refactor/sdk-structure branch from b1084fd to 3255909 Compare January 31, 2025 16:16
@0xmad 0xmad merged commit 109b590 into dev Jan 31, 2025
23 checks passed
@0xmad 0xmad deleted the refactor/sdk-structure branch January 31, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants