Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(contracts): check the NOTHING_UP_MY_SLEEVE value in Poll test suite #1972

Closed
wants to merge 1 commit into from
Closed

test(contracts): check the NOTHING_UP_MY_SLEEVE value in Poll test suite #1972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/contracts/tests/Poll.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@ describe("Poll", () => {
expect(p.toString()).to.eq(pollId.toString());
// publish the NOTHING_UP_MY_SLEEVE message
const messageData = [NOTHING_UP_MY_SLEEVE];
expect(
NOTHING_UP_MY_SLEEVE === BigInt("8370432830353022751713833565135785980866757267633941821328460903436894336785"),
);
Comment on lines +95 to +97
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I makes sense to check the constant value in tests.
I think the idea is to check this value is inside the tree. Checking the constant value doesn't give any coverage.


for (let i = 1; i < 10; i += 1) {
messageData.push(BigInt(0));
}
Expand Down
Loading