fix: rollback called explicitly working. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspears
commented
Jan 20, 2024
| @@ -33,12 +34,13 @@ const prisma = new PrismaClient({ log: ["query"] }).$extends({ | |||
| ) { | |||
| const tx = prisma.$transaction((txClient) => { | |||
| setTxClient(txClient as unknown as Prisma.TransactionClient); | |||
|
|
|||
| return txPromise.catch((e) => { | |||
| if (e === ROLLBACK) return; | |||
There was a problem hiding this comment.
this swallows the exception that actually triggers the rollback.
jspears
commented
Jan 20, 2024
| @@ -17,7 +18,7 @@ const prisma = new PrismaClient({ log: ["query"] }).$extends({ | |||
|
|
|||
| // a promise for getting the tx inner client | |||
| const txClient = new Promise<Prisma.TransactionClient>((res) => { | |||
| setTxClient = (txClient) => res(txClient); | |||
| setTxClient = res; | |||
jspears
commented
Jan 20, 2024
| const tx2 = await prisma.$begin(); | ||
| await tx2.user.findMany(); | ||
| // const tx2 = await prisma.$begin(); | ||
| // await tx2.user.findMany(); |
There was a problem hiding this comment.
to me the important part to show in transactions is rollback, maybe we should show both.
gyunseo
added a commit
to skkuding/codedang
that referenced
this pull request
Mar 16, 2024
4 tasks
|
@jspears Thanks!! Your PR helped me a lot. |
gyunseo
added a commit
to skkuding/codedang
that referenced
this pull request
Mar 18, 2024
* feat(be): implement transaction extension for prisma client prisma/prisma-client-extensions#47 참고하여 작성했습니다 * feat(be): add transaction extension on index ts file * feat(be): implement transaction rollback for group service unit test * test(be): add comments and type * test(be): add await keyword * test(be): add chai exclude * test(be): delete override prisma service func * test(be): increase timeout for before each hook * test(be): disable timeout for before each hook * test(be): add comment * test(be): fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback was not working when explicitly called.
This PR changes the script to test that and actually call rollback. This code should be much more rigorously tested than this, but alas I do not have time.