Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create assets on release #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

henning-gerhardt
Copy link
Contributor

@henning-gerhardt henning-gerhardt commented Nov 29, 2024

On creating tags for releases this change will introduce an automatic build on Linux, Windows and MacOS to build the needed release assets to use mfakto on this operating systems.

Some information:

  • I used the v0.16-beta2 Windows build as a base for building the assets
  • Creating the Windows version with VS is failing with an error message which I don't know to solve as I has no access to a Windows system. If I get the way how to build them I can include the solution in this pull request or it must be later adjusted.

Edit:

@henning-gerhardt
Copy link
Contributor Author

Maybe super seeded by #13.

Copy link
Contributor

@proski proski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments for #13, they apply here as well.

- uses: actions/checkout@v4
- name: Setup
run: |
brew install pocl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pocl should not be needed to build mfakto on MacOS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my first attempt to build release builds by duplicating the build process from the CI run. So this should be changed in the CI too. But I'm not familiar with MacOS and what there is needed.

@henning-gerhardt
Copy link
Contributor Author

Please see my comments for #13, they apply here as well.

If #13 got merged this pull request is not needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants