-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create assets on release #12
base: master
Are you sure you want to change the base?
Create assets on release #12
Conversation
Maybe super seeded by #13. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments for #13, they apply here as well.
- uses: actions/checkout@v4 | ||
- name: Setup | ||
run: | | ||
brew install pocl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pocl should not be needed to build mfakto on MacOS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was my first attempt to build release builds by duplicating the build process from the CI run. So this should be changed in the CI too. But I'm not familiar with MacOS and what there is needed.
On creating tags for releases this change will introduce an automatic build on Linux, Windows and MacOS to build the needed release assets to use mfakto on this operating systems.
Some information:
Edit:
v
to trigger release asset building but this can be adjusted inbuildrelease.yml
file