Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Eslint 9 with flat config #999

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Migrate to Eslint 9 with flat config #999

merged 1 commit into from
Dec 5, 2024

Conversation

lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented Jul 8, 2024 •
edited
Loading

Summary

Working on moving this project to eslint 8 with the flat config

Sadly the github plugin is not compatible, I created an issue for that: github/eslint-plugin-github#539

Closes: https://github.com/github/primer/issues/4420

@lukasoppermann lukasoppermann added dependencies Pull requests that update a dependency file skip changeset Apply to PRs that should not result in a version bump. labels Jul 8, 2024
@lukasoppermann lukasoppermann self-assigned this Jul 8, 2024
@lukasoppermann lukasoppermann requested review from a team as code owners July 8, 2024 11:43
@lukasoppermann lukasoppermann requested a review from langermank July 8, 2024 11:43
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 84664ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to Preview (Storybook) July 9, 2024 07:07 Inactive
@lukasoppermann lukasoppermann changed the title Migrate to Eslint 9.6.0 Migrate to Eslint 8 with flat config Jul 9, 2024
@lukasoppermann lukasoppermann changed the title Migrate to Eslint 8 with flat config Migrate to Eslint 9 with flat config Dec 2, 2024
@lukasoppermann lukasoppermann force-pushed the eslint branch 3 times, most recently from d065bb1 to 53832c9 Compare December 2, 2024 14:21
@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 2, 2024 14:32 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 2, 2024 15:36 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 2, 2024 15:45 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 2, 2024 16:16 Inactive
@github-actions github-actions bot temporarily deployed to Preview (Storybook) December 5, 2024 08:11 Inactive
@lukasoppermann lukasoppermann merged commit 813e375 into main Dec 5, 2024
27 checks passed
@lukasoppermann lukasoppermann deleted the eslint branch December 5, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/css-reviewers

Assignees

@lukasoppermann lukasoppermann

Labels
dependencies Pull requests that update a dependency file skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasoppermann @jonrohan