Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6008: Tooltip - stuck when several tooltips and targets are used together #7590

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

andreev-artem
Copy link
Contributor

Defect Fixes

fix: #6008

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 6:31am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 6:31am

@melloware
Copy link
Member

Thanks for the PR!

@melloware melloware merged commit 7025306 into primefaces:master Jan 10, 2025
4 of 5 checks passed
@andreev-artem
Copy link
Contributor Author

Weird, got the notification about failing unit-test only after merging. @melloware, what should be done now? Revert + new PR with more correct fix?

@melloware
Copy link
Member

@andreev-artem no you can probably just fix the unit test and review it? I agree with your fix the Unit test might be bad.

@melloware
Copy link
Member

@andreev-artem i just submitted this please review: #7591

@andreev-artem
Copy link
Contributor Author

@melloware , great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip: Stuck when several tooltips and targets are used together
2 participants