fix(Calendar): resolve invalid date error in validateDate function

[KumJungMin]

Defect Fixes

• fix: Calendar: Using "minDate" with "yearNavigator" removes previous selected date on selection #7422

How To Resolve

Situation:

• When setting minDate data in yearNavigator mode, an error occurs that causes the selected date to be cleared (reset).

Problem Cause:

• minYear is originally intended to be used as a year (number), but under certain conditions, the props.minDate (Date type) is assigned directly.
• Specifically, the issue arises in the following code:

function validateDate = (value) => {
  const minYear = props.minDate && minRangeYear != null 
      ? Math.max(props.minDate.getFullYear(), minRangeYear) 
      : props.minDate  /* (1) props.minDate (Date object) is assigned to minYear */
        || minRangeYear;

    ...

    if (minYear && minYear > viewYear) {    /* (2) this condition is true */
        viewYear = minYear;                 /* (3) viewYear is set to minYear (Date object). */
    }

    ...

   /* (4) setFullYear is called with a Date object, resulting in 'Invalid Date' error */
   value.setFullYear(viewYear);            
}

Proposed Solution

• By using getFullYear(), we extract only the numerical year from props.minDate and props.maxDate.

function validateDate = (value) => {
  ...
  if (minRangeYear !== null) {
      minYear = props.minDate ? Math.max(props.minDate.getFullYear(), minRangeYear) : minRangeYear;
  } else {
      minYear = props.minDate?.getFullYear() || minRangeYear; /* use getFullYear() */
  }
}

Test

before: After selecting a date and clicking the input, the selected date is cleared.

2025-01-08.9.50.41.mov

<Calendar value={date} yearNavigator onChange={(e) => setDate(e.value)} minDate={minDate} />

after: After selecting a date and clicking the input, the selected date remains intact.

2025-01-08.9.50.03.mov

<Calendar value={date} yearNavigator onChange={(e) => setDate(e.value)} minDate={minDate} />

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Updated (UTC)
primereact	⬜️ Ignored (Inspect)	Visit Preview	Jan 8, 2025 0:55am
primereact-v9	⬜️ Ignored (Inspect)	Visit Preview	Jan 8, 2025 0:55am