Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7045: MenuItem remove aria-hidden #7562

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Fix #7045: MenuItem remove aria-hidden #7562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion components/lib/contextmenu/ContextMenuSub.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,6 @@ export const ContextMenuSub = React.memo(
const actionProps = mergeProps(
{
href: item.url || '#',
'aria-hidden': true,
tabIndex: -1,
className: cx('action', { item }),
target: item.target
Expand Down
1 change: 0 additions & 1 deletion components/lib/dock/Dock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ export const Dock = React.memo(
href: url || '#',
onFocus: (event) => event.stopPropagation(),
className: cx('action', { disabled }),
'aria-hidden': 'true',
tabIndex: -1,
target,
'data-pr-tooltip': label,
Expand Down
3 changes: 1 addition & 2 deletions components/lib/megamenu/MegaMenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -831,8 +831,7 @@ export const MegaMenu = React.memo(
href: item.url || '#',
className: cx('action', { item }),
target: item.target,
tabIndex: '-1',
'aria-hidden': true
tabIndex: '-1'
},
getPTOptions(processedItem, 'action', index)
);
Expand Down
1 change: 0 additions & 1 deletion components/lib/menu/Menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,6 @@ export const Menu = React.memo(
target: item.target,
tabIndex: '-1',
'aria-label': item.label,
'aria-hidden': true,
'aria-disabled': item.disabled,
'data-p-disabled': item.disabled
},
Expand Down
1 change: 0 additions & 1 deletion components/lib/menubar/MenubarSub.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ export const MenubarSub = React.memo(
{
href: item.url || '#',
tabIndex: '-1',
'aria-hidden': 'true',
className: cx('action', { disabled }),
onFocus: (event) => event.stopPropagation(),
target: getItemProp(processedItem, 'target'),
Expand Down
3 changes: 1 addition & 2 deletions components/lib/panelmenu/PanelMenuSub.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,7 @@ export const PanelMenuSub = React.memo(
className: cx('action', { item }),
target: item.target,
onFocus: (event) => event.stopPropagation(),
tabIndex: '-1',
'aria-hidden': true
tabIndex: '-1'
},
getPTOptions(processedItem, 'action', index)
);
Expand Down
1 change: 0 additions & 1 deletion components/lib/tieredmenu/TieredMenuSub.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,6 @@ export const TieredMenuSub = React.memo(
const actionProps = mergeProps(
{
href: url || '#',
'aria-hidden': true,
tabIndex: '-1',
onFocus: (event) => event.stopPropagation(),
className: cx('action'),
Expand Down
Loading