Fix(Calendar): Improve type declaration using generic types with default parameters (Fixes #7555) #7556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #7555
Fix #6583
Summary
This PR implements the proposed improvement by replacing type overloading with generic types for
CalendarProps
. It addresses the problem with dynamically managingselectionMode
as discussed in the issue.Screenshots
I've checked the solution by creating a small wrapper inside the project. Here is a screenshot where you can see that TypeScript correctly defines the
onChange
event type based on the passedselectionMode
.Default (single):
Multiple: