-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance (datatable): avoiding unnecessary re-render of cells of rows with no state-change #7420
Open
acc-cassio
wants to merge
9
commits into
primefaces:master
Choose a base branch
from
acc-cassio:dtable-performance
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odyCell should re-render.
…y avoiding unnecessary re-render of cells. CAREFUL: some bugs detected related to MetaKey which are still not yet fixed.
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
There might still be a bug when the metakey is used for column sorting. I'll verify this later today or tomorrow. |
melloware
requested changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic just one recommendation
melloware
added
the
Status: Pending Review
Issue or pull request is being reviewed by Core Team
label
Nov 15, 2024
…and getNestedValue from BodyCell.js to ObjectUtils and ran prettier to avoid pull request errors
melloware
approved these changes
Nov 15, 2024
acc-cassio
changed the title
Dtable performance
Performance (datatable): avoiding unnecessary re-render of cells of rows with no state-change
Nov 17, 2024
melloware
added
the
Type: Performance
Issue is performance or optimization related
label
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Pending Review
Issue or pull request is being reviewed by Core Team
Type: Performance
Issue is performance or optimization related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fix #2979: Datatable performance improved by taking out parameters and functions of the BodyCells and placing in the BodyRow or TableBody components. Also, the set of BodyCell props to be checked when deciding for a re-render in React.memo was improved. This avoids now a lot of unnecessary re-render, including the issue from the linked issue.
Note that I also created a function called "selectiveCompare" in the BodyCell component to make the selection of which props should be checked at the React.memo. Maybe it makes sense to move it to the Utils, since it potentially can be used for optimizing the datatable further and more generally other library components. This selective comparison of the props is important since React.memo will not work as expected mainly if there are objects being parsed in the props.