Merge pull request #6224 from melloware/PR6223

Fix #6223: RadioButton onChange called twice
primefaces · Mar 26, 2024 · db3d6cb · db3d6cb
2 parents 4cafa77 + d05353d
commit db3d6cb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/components/lib/checkbox/Checkbox.js b/components/lib/checkbox/Checkbox.js
@@ -56,7 +56,7 @@ export const Checkbox = React.memo(
                     }
                 };
 
-                props.onChange && props.onChange(eventData);
+                props?.onChange?.(eventData);
 
                 // do not continue if the user defined click wants to prevent
                 if (event.defaultPrevented) {

diff --git a/components/lib/radiobutton/RadioButton.js b/components/lib/radiobutton/RadioButton.js
@@ -57,16 +57,14 @@ export const RadioButton = React.memo(
                     }
                 };
 
-                props?.onChange?.(eventData);
-
-                // do not continue if the user defined click wants to prevent
-                if (event.defaultPrevented) {
-                    return;
-                }
-
                 if (isInputToggled || isRadioToggled) {
                     props?.onChange?.(eventData);
 
+                    // do not continue if the user defined click wants to prevent
+                    if (event.defaultPrevented) {
+                        return;
+                    }
+
                     if (isRadioToggled) {
                         inputRef.current.checked = value;
                     }
@@ -163,7 +161,7 @@ export const RadioButton = React.memo(
 
             return (
                 <div {...boxProps}>
-                    <div {...iconProps}></div>
+                    <div {...iconProps} />
                 </div>
             );
         };