Skip to content

Commit

Permalink
Fix #7343: Remove aria-hidden as not needed from focusable elements (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
melloware authored Jan 6, 2025
1 parent 66acd1d commit 701f9df
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
5 changes: 1 addition & 4 deletions components/lib/dropdown/Dropdown.js
Original file line number Diff line number Diff line change
Expand Up @@ -985,8 +985,7 @@ export const Dropdown = React.memo(
required: props.required,
defaultValue: option.value,
name: props.name,
tabIndex: -1,
'aria-hidden': 'true'
tabIndex: -1
},
ptm('select')
);
Expand Down Expand Up @@ -1198,7 +1197,6 @@ export const Dropdown = React.memo(
{
ref: firstHiddenFocusableElementOnOverlay,
role: 'presentation',
'aria-hidden': 'true',
className: 'p-hidden-accessible p-hidden-focusable',
tabIndex: '0',
onFocus: onFirstHiddenFocus,
Expand All @@ -1212,7 +1210,6 @@ export const Dropdown = React.memo(
{
ref: lastHiddenFocusableElementOnOverlay,
role: 'presentation',
'aria-hidden': 'true',
className: 'p-hidden-accessible p-hidden-focusable',
tabIndex: '0',
onFocus: onLastHiddenFocus,
Expand Down
2 changes: 0 additions & 2 deletions components/lib/multiselect/MultiSelectPanel.js
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,6 @@ export const MultiSelectPanel = React.memo(
{
ref: props.firstHiddenFocusableElementOnOverlay,
role: 'presentation',
'aria-hidden': 'true',
className: 'p-hidden-accessible p-hidden-focusable',
tabIndex: '0',
onFocus: props.onFirstHiddenFocus,
Expand All @@ -312,7 +311,6 @@ export const MultiSelectPanel = React.memo(
{
ref: props.lastHiddenFocusableElementOnOverlay,
role: 'presentation',
'aria-hidden': 'true',
className: 'p-hidden-accessible p-hidden-focusable',
tabIndex: '0',
onFocus: props.onLastHiddenFocus,
Expand Down

0 comments on commit 701f9df

Please sign in to comment.