Fixed #4656 - DataTable: memory leak when data updated continuously

primefaces · Nov 25, 2023 · 2f1d1c5 · 2f1d1c5
1 parent 034afc2
commit 2f1d1c5
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/components/lib/hooks/useEventListener.js b/components/lib/hooks/useEventListener.js
@@ -7,7 +7,6 @@ import { useUnmountEffect } from './useUnmountEffect';
 export const useEventListener = ({ target = 'document', type, listener, options, when = true }) => {
     const targetRef = React.useRef(null);
     const listenerRef = React.useRef(null);
-    const prevListener = usePrevious(listener);
     const prevOptions = usePrevious(options);
 
     const bind = (bindOptions = {}) => {
@@ -39,12 +38,11 @@ export const useEventListener = ({ target = 'document', type, listener, options,
     }, [target, when]);
 
     React.useEffect(() => {
-        // to properly compare functions we can implicitly converting the function to it's body's text as a String
-        if (listenerRef.current && ('' + prevListener !== '' + listener || prevOptions !== options)) {
+        if (listenerRef.current && (listenerRef.current !== listener || prevOptions !== options)) {
             unbind();
             when && bind();
         }
-    }, [listener, options, when]);
+    }, [listener, options]);
 
     useUnmountEffect(() => {
         unbind();