Fix #6944: Improve Checkbox PT Options in MultiSelect (#6945)

* fix: use correct type definition, reflecting usage in code * fix: no need for checkbox icon pt options, part of checkbox pt option * fix: no need for header checkbox icon pt options, part of header checkbox pt option --------- Co-authored-by: Pascal Economou <[email protected]>
primefaces · Jul 29, 2024 · 22addcc · 22addcc
1 parent 9153b42
commit 22addcc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/components/lib/multiselect/MultiSelectHeader.js b/components/lib/multiselect/MultiSelectHeader.js
@@ -117,7 +117,7 @@ export const MultiSelectHeader = React.memo((props) => {
         {
             className: cx('headerCheckboxIcon')
         },
-        getPTOptions('headerCheckboxIcon')
+        getPTOptions('headerCheckbox.icon')
     );
 
     const headerCheckboxContainerProps = mergeProps(

diff --git a/components/lib/multiselect/MultiSelectItem.js b/components/lib/multiselect/MultiSelectItem.js
@@ -46,7 +46,7 @@ export const MultiSelectItem = React.memo((props) => {
         {
             className: cx('checkboxIcon')
         },
-        getPTOptions('checkboxIcon')
+        getPTOptions('checkbox.icon')
     );
 
     const icon = props.checkboxIcon || <CheckIcon {...checkboxIconProps} />;

diff --git a/components/lib/multiselect/multiselect.d.ts b/components/lib/multiselect/multiselect.d.ts
@@ -96,10 +96,6 @@ export interface MultiSelectPassThroughOptions {
      * Uses to pass attributes to the header checkbox's container DOM element.
      */
     headerCheckboxContainer?: MultiSelectPassThroughType<React.HTMLAttributes<HTMLDivElement>>;
-    /**
-     * Uses to pass attributes to the header checkbox icon's DOM element.
-     */
-    headerCheckboxIcon?: MultiSelectPassThroughType<React.SVGProps<SVGSVGElement> | React.HTMLAttributes<HTMLSpanElement>>;
     /**
      * Uses to pass attributes to the header checkbox's DOM element.
      */
@@ -152,11 +148,7 @@ export interface MultiSelectPassThroughOptions {
     /**
      * Uses to pass attributes to the checkbox's DOM element.
      */
-    checkbox?: MultiSelectPassThroughType<React.HTMLAttributes<HTMLDivElement>>;
-    /**
-     * Uses to pass attributes to the checkbox icon's DOM element.
-     */
-    checkboxIcon?: MultiSelectPassThroughType<React.SVGProps<SVGSVGElement> | React.HTMLAttributes<HTMLSpanElement>>;
+    checkbox?: CheckboxPassThroughOptions;
     /**
      * Uses to pass attributes to the emptyMessage's DOM element.
      */