Fix #16246 TreeTable Spacer Size Calculation #16273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
johannes-wolf
force-pushed
the
fix-virtual-treetable-scrolling
branch
from
f1804a5
to
c879951
Compare
johannes-wolf
changed the title
johannes-wolf
force-pushed
the
fix-virtual-treetable-scrolling
branch
from
c879951
to
022c5a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fixes #16246
Commit e7b611 introduced a regression in the size calculation for
TreeTablecomponent with a"flex"height configuration. The issue arises because the spacer size is no longer being updated correctly. As a result, the scrollbar resizes itself during scrolling, which causes jumping of the scrollbar.I have replaced the window-size listener with a
ResizeObserver, because the number of visible items in aTreeTablewith virtual scrolling must get recalculated if the view size changes. The new observer should handle window size changes, important to theTreeTable, equally well.