-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple fixes for class attribute conversions #509
Conversation
This PR is ready for review and would close #508 if deemed merge-worthy. |
Back from vacation, I'll have a look the next few days, because I need to ensure that everything is correct |
Added 1-level indentation tests and made use of I just saw that for some cases we have still a |
Closes #508
This PR adds tests and fixes for previously untested variations of class literals in increasingly complex scenarios. Most of them output non-valid Pug code currently.
I fixed all the new test cases to output valid Pug code without regressions, so this is probably safe to merge. I don't have full confidence that there are no other (currently untested) bad combinations of the various options, but this is for sure better than before.
Examples of code that previously outputted invalid Pug but now work: