adds SpecifiedLegalOrganization #28
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 91.09% 90.51% -0.59%
==========================================
Files 17 17
Lines 1382 1392 +10
==========================================
+ Hits 1259 1260 +1
- Misses 123 132 +9 ☔ View full report in Codecov by Sentry. |
drafthorse/models/party.py
Outdated
| @@ -59,6 +59,22 @@ class Meta: | |||
| tag = "EmailURIUniversalCommunication" | |||
|
|
|||
|
|
|||
| class LegalOrganization(Element): | |||
| id = StringField(NS_RAM, "ID", required=False, profile=BASIC) | |||
There was a problem hiding this comment.
Maybe this should be an IDField as it reads type="udt:IDType" in the spec which allows for an optional schemeID. There are other places where StringFields might need to be promoted to IDFields.
drafthorse/models/party.py
Outdated
| "TradingBusinessName", | ||
| required=False, | ||
| profile=BASIC, | ||
| _d="Name, unter dem der Käufers bekannt ist", |
There was a problem hiding this comment.
Can you please fix the typo "Käufers" here? ;-)
btw, this scheme is to be used for seller and buyer. Maybe just "Firmenname, sofern abweichend vom Name" will fit better?
There was a problem hiding this comment.
I did but in my fork, but my commits are not synced with this PR. I tried somethings already (close-reopen RP, set different base and back), but nothing worked. Any idea how I could get this PR back in sync with the source branch in my fork?
No description provided.