Adds url parse and removes the usage of anchor #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates url parse import name Updates dependencies on package.json
|
@eluciano11 thanks so much for jumping on this!! @xg-wang Can we go ahead and merge this, and deal with the IE testing later? Since we don't have IE test coverage for the rest of Pretender I don't think it should be a blocker for this PR. |
|
@samselikoff no problem, happy to help! |
xg-wang
approved these changes
Feb 6, 2020
There was a problem hiding this comment.
Thanks @eluciano11 the change looks good!
url-parse has cross-browser testing coverage I agree it's not a blocker for this PR.
|
Hi @eluciano11 is this still draft or it's ready be merged? |
|
@xg-wang should be good to go! |
|
Awesome, thanks again! We can take care of ie coverage elsewhere. |
This was referenced Feb 6, 2020
Closed
|
Np, sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed and why
This PR replaces the usage of
documentto parse a URL with the libraryurl-parse. By doing this Pretender can be used in environments that don't include the DOM such as React Native.The work done here is based on this PR #267. Additionally I added a couple of fixes that @xg-wang requested.
The only review comments that are pending from the old PR are the following:
#267 (comment)
#267 (comment)
To solve the pending issues I originally thought of using the Karma launcher for IE but that won't work on a IE environment because we won't have an IE binary. I was thinking that we could use SauceLabs or BrowserStack to run the tests on different browsers.
I would appreciate it if @xg-wang or @samselikoff would share their thoughts on how the IE issue could be solved. If we decide to go with SauceLabs we can request an Open Source Account.