-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Pretender is importable in node #269
Conversation
@stefanpenner think this is ready for review! LMK if someone else I should @ |
This works for Pretender's iife build but not it's ES module build, which we found out when trying to use it in a Gatsby app. The problem is We're kinda struggling about what to do here. One option would be to vendor What do you think? Any tips on how to solve this in another way? |
Think we're in a good spot! Gonna test it on some of my projects now |
Seems to be working everywhere \o/ |
There's one more thing... Need more tests to cover ES build case in non-browser environment. |
To clarify, we need to actually run the real functionality tests against the ES build in a browser-like ( |
Closing for now as stale |
Fixes #268