Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macros for map script terminators #1876

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

GriffinRichards
Copy link
Member

This would be a reasonable time to rename map_script_2 to something descriptive like map_script_table, but it might not be worth the conflicts.

This PR won't disrupt poryscript or any new map scripts downstream.

Copy link

@martingaldeca martingaldeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm new checking code in this repo (so not sure if I'm able to approve anything), but it makes sense to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants