feat: allow empty migrations in providers #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR allow the usage of a provider without any version.
When there are no versions, I'm not sure there are a reason to disable provider usage. I would like to be able to use my provider as usual, it's just it's going to tell me there are no migration to apply and no specifying handling of the "I got a provider / I didn't" is needed when using the library.
This mean there won't be an error if someone is initialize the provider without migrations witch may not be desirable. The new behavior may be implemented as an option, or the Provider returned with the error, leaving the choice to the programmer :)