fix: log reason for version table creation #891
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefinal
force-pushed
the
fix-log-reason-for-version-table-creation
branch
from
19606ca to
891486f
Compare
Adds a log entry for when the version table is created, including the reason (original error). This simplifies debugging of environments where users expect version tables to already exist.
lefinal
force-pushed
the
fix-log-reason-for-version-table-creation
branch
from
891486f to
4793bec
Compare
|
Are you using goose as a Go library or the standalone |
@mfridman We use goose as Go library for automated migration on startup and are quite happy with it. We only ran into this issue last week and thought this might be helpful in general :) |
|
Thanks for putting up a PR. I think less logging is ideal, so went with the alternative which is to join the errors in this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a log entry for when the version table is created, including the reason (original error). This simplifies debugging of environments where users expect version tables to already exist.
In our case, a PostgreSQL database was backed up and restored. Despite the version table existing, due to a misconfiguration it could not access it and tried to create it again. Logging the reason why we create the table improves the debugging experience and transparency of what goose is actually doing.